css: Drop a few dynamic type checks
authorTimm Bäder <mail@baedert.org>
Wed, 6 May 2020 09:40:52 +0000 (11:40 +0200)
committerTimm Bäder <mail@baedert.org>
Sun, 10 May 2020 06:44:20 +0000 (08:44 +0200)
We hit these code paths a lot

gtk/gtkcssanimatedstyle.c
gtk/gtkcssstyle.c
gtk/gtkcsstransition.c
gtk/gtkstyleanimation.c

index d67bb9f191ea6061b654d81c9e3b2de78e93778d..c04f040b0b4346f5421134ec2f03c824f8272e29 100644 (file)
@@ -53,7 +53,7 @@ gtk_css_animated_style_get_section (GtkCssStyle *style,
 static gboolean
 gtk_css_animated_style_is_static (GtkCssStyle *style)
 {
-  GtkCssAnimatedStyle *animated = GTK_CSS_ANIMATED_STYLE (style);
+  GtkCssAnimatedStyle *animated = (GtkCssAnimatedStyle *)style;
   guint i;
 
   for (i = 0; i < animated->n_animations; i ++)
index b02c4dd394fcd479a2aea3be1b4818b77377299f..8a15649b74161c26ef9f59b9c8151a53efd4784a 100644 (file)
@@ -293,8 +293,6 @@ gtk_css_style_get_section (GtkCssStyle *style,
 gboolean
 gtk_css_style_is_static (GtkCssStyle *style)
 {
-  gtk_internal_return_val_if_fail (GTK_IS_CSS_STYLE (style), TRUE);
-
   return GTK_CSS_STYLE_GET_CLASS (style)->is_static (style);
 }
 
index 62731a513d1b335bf18944be6549b64cb82b914b..bb872a0b174be955491cb33aebae6aed4b4ea4e7 100644 (file)
@@ -30,8 +30,7 @@ static GtkStyleAnimation *
 gtk_css_transition_advance (GtkStyleAnimation    *style_animation,
                            gint64                timestamp)
 {
-  GtkCssTransition *source = GTK_CSS_TRANSITION (style_animation);
-
+  GtkCssTransition *source = (GtkCssTransition *)style_animation;
   GtkCssTransition *transition;
 
   transition = g_object_new (GTK_TYPE_CSS_TRANSITION, NULL);
@@ -44,14 +43,14 @@ gtk_css_transition_advance (GtkStyleAnimation    *style_animation,
   gtk_progress_tracker_advance_frame (&transition->tracker, timestamp);
   transition->finished = gtk_progress_tracker_get_state (&transition->tracker) == GTK_PROGRESS_STATE_AFTER;
 
-  return GTK_STYLE_ANIMATION (transition);
+  return (GtkStyleAnimation *)transition;
 }
 
 static void
 gtk_css_transition_apply_values (GtkStyleAnimation   *style_animation,
                                  GtkCssAnimatedStyle *style)
 {
-  GtkCssTransition *transition = GTK_CSS_TRANSITION (style_animation);
+  GtkCssTransition *transition = (GtkCssTransition *)style_animation;
   GtkCssValue *value, *end;
   double progress;
   GtkProgressState state;
@@ -86,7 +85,7 @@ gtk_css_transition_apply_values (GtkStyleAnimation   *style_animation,
 static gboolean
 gtk_css_transition_is_finished (GtkStyleAnimation *animation)
 {
-  GtkCssTransition *transition = GTK_CSS_TRANSITION (animation);
+  GtkCssTransition *transition = (GtkCssTransition *)animation;
 
   return transition->finished;
 }
@@ -94,7 +93,7 @@ gtk_css_transition_is_finished (GtkStyleAnimation *animation)
 static gboolean
 gtk_css_transition_is_static (GtkStyleAnimation *animation)
 {
-  GtkCssTransition *transition = GTK_CSS_TRANSITION (animation);
+  GtkCssTransition *transition = (GtkCssTransition *)animation;
 
   return transition->finished;
 }
index 89f8319fba3800f6636ed8c36de4f60f146eb1ca..754f09b0c09151125ebf97b30993d3a25f984a4b 100644 (file)
@@ -117,8 +117,6 @@ _gtk_style_animation_is_static (GtkStyleAnimation *animation)
 {
   GtkStyleAnimationClass *klass;
 
-  g_return_val_if_fail (GTK_IS_STYLE_ANIMATION (animation), TRUE);
-
   klass = GTK_STYLE_ANIMATION_GET_CLASS (animation);
 
   return klass->is_static (animation);